fix(appengine): Restore build products to previous location #6687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify the prepareDemos script to copy the messages and compressed files to their previous locations in the deploy directory, to fix 404 errors on devsite that we can't immediately fix by pushing devsite.
NeilFraser
approved these changes
Dec 7, 2022
|
Holding off merging this until deployed successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
developmasterdevelopmasternpm run formatandnpm run lintThe details
Resolves
Temporary fix for #6609, fixing 404 errors on devsite that break the homepage demo (for languages other than English, which has already been successfully fixed by making changes to devsite).
Proposed Changes
Modify the
prepareDemosscript to copy the messages and compressed files to their previous locations in the deploy directoryBehaviour Before Change
Build products are copied to
_deploy/static/build/msg/and_deploy/static/dist/, matching their usual locations in the Blockly repo.Behaviour After Change
Build products are additionally copied to
_deploy/static/msg/js/and_deploy/static/, matching their locations in the Blockly repo prior to PR #6475.Reason for Changes
The demo on the Blockly Developers website homepage was broken by #6475 and we have only been able to fix by updating devsite for English so far; it remains broken in other languages due delays in updating the other languages.
Additional Information
This change should be reverted once devsite is fully updated.