fix: insertion markers firing move events #7005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeilFraser
approved these changes
Apr 21, 2023
BeksOmega
added a commit
that referenced
this pull request
Apr 26, 2023
(cherry picked from commit 35276e9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes #7002
Proposed Changes
Reverts reordering hiding and connecting. It is more efficient to connect "on top" of another connection, because then we can avoid setting the block's parent element twice. But this only saves ~12ms from wrapping an
ifaround the spaghetti blocks. So I think correctness is better in this case.Test Coverage
Just manual testing.
Documentation
N/A
Additional Information
Broken by #6876