feat: connection highlighter interface #7638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
force-pushed
the
feat/connection-highlighter-interface
branch
from
934ee2a
to
0d0f377
Compare
NeilFraser
approved these changes
Nov 17, 2023
BeksOmega
added a commit
to BeksOmega/blockly
that referenced
this pull request
Feb 2, 2024
* feat: add connection highlighter interface * fix: remove unnecessary method from the path object interface
BeksOmega
added a commit
that referenced
this pull request
Feb 2, 2024
* feat: add connection highlighter interface * fix: remove unnecessary method from the path object interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Work on #7204
Proposed Changes
Adds a connection highlighter interface for future use. Removes unnecessary methods from the path object interface.
Reason for Changes
Working on unifying how highlighting connections works so that implementing different connection previewers is simpler.
Test Coverage
No tests yet because this just defines types not behavior.
Documentation
N/A
Additional Information
Merging against a feature branch because I'm not sure I can get this done by time for release.