Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mutator coordinates not respecting flyout #7690

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

BeksOmega
Copy link
Collaborator

@BeksOmega BeksOmega commented Dec 4, 2023

The basics

The details

Resolves

Fixes #7677

Proposed Changes

Re-adds logic for setting absolute metrics in the flyout code removed in https://github.com/google/blockly/pull/7634/files#r1385439054

Reason for Changes

Unbork borkedness.

Test Coverage

  • Manually tested mutators.
  • Tested that setting the autoclose-ness of flyouts on workspaces with scrollbars still properly updates the absolute metrics.

Documentation

N/A

Additional Information

Filed #7689 to track actually fixing this.

@BeksOmega BeksOmega requested a review from a team as a code owner December 4, 2023 16:36
@github-actions github-actions bot added PR: fix Fixes a bug and removed PR: fix Fixes a bug labels Dec 4, 2023
@cpcallen cpcallen requested review from cpcallen and removed request for NeilFraser December 5, 2023 18:11
core/flyout_horizontal.ts Outdated Show resolved Hide resolved
core/flyout_horizontal.ts Show resolved Hide resolved
@BeksOmega BeksOmega merged commit 45cc1e8 into google:develop Dec 5, 2023
6 checks passed
@BeksOmega BeksOmega deleted the fix/mutator-coords branch May 14, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All mutators have broken workspace coordinates.
3 participants