feat: connection highlight zelos #7781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
PR: feature
BeksOmega
force-pushed
the
feat/connection-highlight-zelos
branch
from
6a1e65a
to
3d32f1e
Compare
cpcallen
approved these changes
Jan 11, 2024
github-actions
bot
added
PR: feature
|
Thank you for the review Christopher! :D |
BeksOmega
added a commit
to BeksOmega/blockly
that referenced
this pull request
Feb 2, 2024
* feat: add connection highlighting to zelos * fix: drawing outputs * chore: cleanup
BeksOmega
added a commit
that referenced
this pull request
Feb 2, 2024
* feat: add connection highlighting to zelos * fix: drawing outputs * chore: cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Work on #7204
Proposed Changes + reasons
Makes it so that zelos has the ability to highlight connections, so the eventual connection previewer system can call the renderer to highlight connections consistently (instead of sometimes calling the renderer, and sometimes doing other things).
Test Coverage
Manually tested highlighting all three shapes of dynamic connections in zelos (hexagon, rounded, and square). Manually tested highlighting non-dynamic connections (puzzle tabs).
Documentation
N/A
Additional Information
N/A
To Review
The drawer architecture is... a bit frustrating. All of the methods are stateful, so I had to pull out some logic for creating internal input paths into pure methods. This way the code could be reused.
Some of the "constants" for path shapes were also broken. Previously
pathDown()was never being called, so no one noticed that it was busted. I fixed up the logic to actually work for all combinations of right or left side + drawing up or down.[Edit: docs for context https://developers.google.com/blockly/guides/create-custom-blocks/renderers/create-custom-renderers/connection-shapes#basic_shapes]