fix!: have disposing be true from start of dispose #7891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
breaking change
BeksOmega
force-pushed
the
fix/disposing-value
branch
from
cda8d2a
to
4bbd132
Compare
github-actions
bot
removed
PR: fix
github-actions
bot
added
breaking change
cpcallen
approved these changes
Mar 13, 2024
| @@ -795,7 +795,7 @@ export class BlockSvg | |||
| * E.g. does trigger UI effects, remove nodes, etc. | |||
| */ | |||
| override disposeInternal() { | |||
| if (this.isDeadOrDying()) return; | |||
| this.disposing = true; | |||
There was a problem hiding this comment.
I am pretty sure that this one is redundant and can be removed, since you do a super call immediately and Block.prototype.disposeInternal also sets this.disposing = true.
There was a problem hiding this comment.
I agree, but to future-proof this (in case we ever add things before calling super) and make it extremely clear, I think it's reasonable to leave it in.
If this were more expensive I would remove it. But since it's cheap I think it's reasonable to leave.
github-actions
bot
added
breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #7864
Proposed Changes
Makes it so
disposingis set at the beginning of thedisposeanddisposeInternalmethods.Reason for Changes
This way we can check
isDeadOrDyingin the dynamic connection plugin to get around issues with the dynamic connection plugin (see the linked issue for more detail).Test Coverage
Updated incorrect tests.
Documentation
N/A
Additional Information
N/A
Breaking changes / To fix
The
disposingproperty is now true from the start of the call todisposeon blocks. Whereas before, it would only be true after we had removed top blocks, change listeners, and done a few other actions. This means thatisDeadOrDyingreturns true from the start of the call todispose.We think its unlikely that anyone was depending on the "delay" in the change to this value. So there is likely no work you need to do here. If you run into problems with this change, please let us know.