feat: have RenderedWorkspaceComment implement IBoundedElement and IRenderedElement #7919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
force-pushed
the
feat/comment-bound-render
branch
4 times, most recently
from
078c372
to
ad2f963
Compare
BeksOmega
force-pushed
the
feat/comment-bound-render
branch
2 times, most recently
from
75a6b98
to
9d1c5f8
Compare
BeksOmega
force-pushed
the
feat/comment-bound-render
branch
from
9d1c5f8
to
e48305a
Compare
cpcallen
approved these changes
Mar 19, 2024
|
BTW, the pull request title could be more clear. Perhaps:
|
|
BTW, the pull request title could be more clear. Perhaps something like:
|
BeksOmega
changed the title
github-actions
bot
added
PR: feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Work on #7907
Proposed Changes + Reasons
Adds support for these interfaces so that rendered workspace comments can be used in places where those interfaces are required (e.g. bumping elements into bounds).
Test Coverage
N/A
Documentation
N/A
Additional Information
N/A