Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update help URL per #937. #956

Merged
merged 1 commit into from Feb 28, 2017
Merged

Update help URL per #937. #956

merged 1 commit into from Feb 28, 2017

Conversation

AnmAtAnm
Copy link
Contributor

Replace URL usages of %28 and %29 with normal parenthesis characters. (They aren't replaced by JavaScript's encodeURIComponent() function, and seem to work just fine without them.)
Added missing semicolon in build.py.
@AnmAtAnm AnmAtAnm merged commit 16380ab into google:develop Feb 28, 2017
@NeilFraser
Copy link
Member

NeilFraser commented Feb 28, 2017

This change should also be made to JSON language files that are using the English URLs. For example:
https://github.com/google/blockly/blob/master/msg/json/br.json#L303
Some languages such as 'az' don't specify a URL, so they float to the English version. Others like 'br' have explicitly copied the English.

@AnmAtAnm AnmAtAnm deleted the msg-urls branch May 5, 2017 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants