Append dom to workspace #961
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated Blockly.Xml.domToWorkspace to load previously saved "blocks" below the existing blocks
The function align the newly loaded blocks below the exisiting blocks
Add function appendDomToWorkspace to compute offset of x and y and call domToWorkspace; modified domToWorkspace to accept offset value; modified test_domToWorkspace to test the new parameter; add a test_appendDomToWorkspace to xml_test.js
…e_domToWorkspace_QN # Conflicts: # tests/jsunit/xml_test.js
domToWorkspace return array of new block ids appendDomToWorkspace call domToWorkspace then move the blocks One test added to workspace_svg_test
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
AnmAtAnm
added a commit
to AnmAtAnm/blockly
that referenced
this pull request
Mar 3, 2017
AnmAtAnm
added a commit
that referenced
this pull request
Mar 3, 2017
This is a copy (with additional comments) of PR #822 (and also #961) by @qnoirhomme with unrelated files removed. See #822 for full review.
|
This PR still has numerous unrelated files. I've made my own PR of the relevant code in #962. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request related to the previous pull request #822 .
A new function appendDomToWorkspace is created which append new blocks below any existing blocks in the workspace. domToWorkspace is modified to return the list of new block ids.