This repository has been archived by the owner on May 6, 2021. It is now read-only.
Fix ReplaceExtension #345
Closed
Fix ReplaceExtension #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReplaceExtension had an unexpected behaviour when the file did not have an extension. In certain cases, the final path would be severely trimmed: out/.intermediates/my_file would become out/.new_extension. Explicitly handle the case by appending the new extension. Test: Run checkbuild on Android Soong Change-Id: Ie27a98845894cfaee5af5e2a02d44168c40ed821
colincross
reviewed
Feb 17, 2021
|
Nevermind, I used copybara to import it as https://android-review.googlesource.com/c/platform/build/blueprint/+/1591572 |
copybara-service bot
pushed a commit
that referenced
this pull request
Feb 17, 2021
ReplaceExtension had an unexpected behaviour when the file did not have an extension. In certain cases, the final path would be severely trimmed: out/.intermediates/my_file would become out/.new_extension. Explicitly handle the case by appending the new extension. Test: Run checkbuild on Android Soong Change-Id: Ie27a98845894cfaee5af5e2a02d44168c40ed821 This is an imported pull request from #345 GitOrigin-RevId: f9166c0 Change-Id: I63f0798177545792440b8a84b04f1090590f1642
|
Great, thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReplaceExtension had an unexpected behaviour when the file did not have
an extension. In certain cases, the final path would be severely
trimmed: out/.intermediates/my_file would become out/.new_extension.
Explicitly handle the case by appending the new extension.
Test: Run checkbuild on Android Soong
Change-Id: Ie27a98845894cfaee5af5e2a02d44168c40ed821