This repository has been archived by the owner on May 6, 2021. It is now read-only.
Add common implicit deps to Rules #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, I'm actually seeing some failures with the latest patch. I'll reopen once I've fixed them. |
For implicit dependencies that will be common to all users of a Rule, add a new field 'CommandDeps' to the RuleParam. This is a list of strings to be prepended to the implicit dependencies in each BuildParam. This lets us have the dependencies declared next to where they are used, instead of duplicated in areas that may be far apart. I looked at passing this information down to ninja too, but it only saves us a few percent of ninja file, and requires a modification to the ninja file format. Change-Id: Ifd910dee1506d4e32a76ed06206f853c4caec622
|
Fixed (variable scoping was wrong in live_tracker.go) |
|
LGTM |
danw
added a commit
that referenced
this pull request
Nov 18, 2015
Add common implicit deps to Rules
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For implicit dependencies that will be common to all users of a Rule,
add a new field 'CommandDeps' to the RuleParam. This is a list of
strings to be prepended to the implicit dependencies in each BuildParam.
This lets us have the dependencies declared next to where they are used,
instead of duplicated in areas that may be far apart.
I looked at passing this information down to ninja too, but it only
saves us a few percent of ninja file, and requires a modification to the
ninja file format.