Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GOBMCN2-166 - documentation updates #51

Merged
merged 7 commits into from
Oct 20, 2020
Merged

GOBMCN2-166 - documentation updates #51

merged 7 commits into from
Oct 20, 2020

Conversation

pythiangoryunov
Copy link
Contributor

user-guide.md
-- add quick references for RAC and DR deployments
-- update of PSU and RU patches

user-guide.md
-- add quick references for RAC and DR deployments
-- update of PSU and RU patches
Copy link
Contributor

@bpj146 bpj146 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested several revisions to improve clarity, grammar, and style.

docs/user-guide.md Outdated Show resolved Hide resolved
docs/user-guide.md Outdated Show resolved Hide resolved
1. Create cluster config file. The file `cluster_config.json` is provided as template
and should be updated accordingly.

1. Run installation pointing to the file for planned cluster configuration:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion:
"Install the database with the path to the cluster configuration file specified on the --cluster-config property:"

docs/user-guide.md Outdated Show resolved Hide resolved
Before creation of standby database the primary host and its database should exist.

The primary database creation can be performed using [Single Instance Deployments section](#command-quick-reference-for-single-instance-deployments)<br>
without or set to NONE `--cluster-type` option.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you create the primary database, omit the --cluster-type option or set it to NONE. To create the primary database, see Single Instance Deployments.

docs/user-guide.md Show resolved Hide resolved
docs/user-guide.md Outdated Show resolved Hide resolved
made the changes according to the comments
@pythiangoryunov
Copy link
Contributor Author

I made the changes and pushed them to the branch

@bpj146
Copy link
Contributor

bpj146 commented Oct 13, 2020

There are a couple of outstanding comments in the review still.

Also, my review is only an editorial review. Marc should sign of on the changes from a technical perspective.

Copy link
Member

@mfielding mfielding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; would you mind updating the parameter reference list to include the changes to --primary-ip-addr and cluster-type?

docs/user-guide.md Outdated Show resolved Hide resolved
docs/user-guide.md Show resolved Hide resolved
removed <br>
added --primary-ip-addr parameter and updated --cluster-type
Copy link
Contributor Author

@pythiangoryunov pythiangoryunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added --primary-ip-addr and option 'DG' to cluster-type description

docs/user-guide.md Show resolved Hide resolved
adjustements of existing parameters, new parameters for cleanup script, updated format of inventory and log files
Copy link
Contributor Author

@pythiangoryunov pythiangoryunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes for parameters

@pythiangoryunov
Copy link
Contributor Author

changed information about parameters and format of inventory and log files, added new parameters for cleanup (changed to come through GOBMCN2-171)

@pythiangoryunov pythiangoryunov merged commit 27bd440 into master Oct 20, 2020
@pythiangoryunov pythiangoryunov deleted the GOBMCN2-166 branch October 30, 2020 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants