-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GOBMCN2-166 - documentation updates #51
Conversation
user-guide.md -- add quick references for RAC and DR deployments -- update of PSU and RU patches
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested several revisions to improve clarity, grammar, and style.
docs/user-guide.md
Outdated
1. Create cluster config file. The file `cluster_config.json` is provided as template | ||
and should be updated accordingly. | ||
|
||
1. Run installation pointing to the file for planned cluster configuration: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion:
"Install the database with the path to the cluster configuration file specified on the --cluster-config property:"
docs/user-guide.md
Outdated
Before creation of standby database the primary host and its database should exist. | ||
|
||
The primary database creation can be performed using [Single Instance Deployments section](#command-quick-reference-for-single-instance-deployments)<br> | ||
without or set to NONE `--cluster-type` option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you create the primary database, omit the --cluster-type
option or set it to NONE
. To create the primary database, see Single Instance Deployments.
made the changes according to the comments
I made the changes and pushed them to the branch |
There are a couple of outstanding comments in the review still. Also, my review is only an editorial review. Marc should sign of on the changes from a technical perspective. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; would you mind updating the parameter reference list to include the changes to --primary-ip-addr and cluster-type?
removed <br>
added --primary-ip-addr parameter and updated --cluster-type
…nto GOBMCN2-166
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added --primary-ip-addr and option 'DG' to cluster-type description
adjustements of existing parameters, new parameters for cleanup script, updated format of inventory and log files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes for parameters
changed information about parameters and format of inventory and log files, added new parameters for cleanup (changed to come through GOBMCN2-171) |
user-guide.md
-- add quick references for RAC and DR deployments
-- update of PSU and RU patches