Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add details for latest RU and code fixes for errors faced #79

Merged
merged 13 commits into from
Jul 21, 2021

Conversation

jcnars
Copy link
Collaborator

@jcnars jcnars commented Jun 26, 2021

Adding code fixes and JAN/APR 2021 RU details.

Will add in-line comments (in each file changed) next week for each of the files submitted for review with detailed error message that necessitated that particular code change and the successful testing of the fix.

Copy link
Member

@mfielding mfielding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work here; this PR seems to include many varied fixes, and I've tried to include comments form all of them. Splitting this into multiple independent PRs might help speed up the review cycle though.

docs/user-guide.md Outdated Show resolved Hide resolved
docs/user-guide.md Outdated Show resolved Hide resolved
patch.yml Outdated Show resolved Hide resolved
patch.yml Outdated Show resolved Hide resolved
patch.yml Outdated Show resolved Hide resolved
roles/common/defaults/main.yml Outdated Show resolved Hide resolved
roles/common/defaults/main.yml Show resolved Hide resolved
roles/common/defaults/main.yml Outdated Show resolved Hide resolved
roles/patch/tasks/rac-opatch.yml Outdated Show resolved Hide resolved
roles/swlib/tasks/gcscopy.yml Show resolved Hide resolved
@jcnars
Copy link
Collaborator Author

jcnars commented Jun 29, 2021

Adding code fixes and JAN/APR 2021 RU details.

Will add in-line comments (in each file changed) next week for each of the files submitted for review with detailed error message that necessitated that particular code change and the successful testing of the fix.

Thanks for the review - the thought of creating multiple PRs crossed my mind, but I have changed these 4 files in a single branch during my testing in cloudVM (control node) and would need to cherry pick them into new branches (as PR is only possible on an entire branch and not commits within that branch).

I will take this lesson forward into the future for sizeable PRs.

Copy link
Member

@mfielding mfielding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost almost there :-)

docs/quarterly_RU_update.md Outdated Show resolved Hide resolved
roles/swlib/tasks/gcscopy.yml Show resolved Hide resolved
docs/user-guide.md Outdated Show resolved Hide resolved
patch.yml Outdated Show resolved Hide resolved
Copy link
Member

@mfielding mfielding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just a few small stylistic things.

# limitations under the License.

---
- name: Patch | include defaults
Copy link
Member

@mfielding mfielding Jul 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

roles/patch/meta/main.yml includes a dependency on common


dependencies:
- { role: common }

So this step should be unnecessary

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

include_vars:
file: roles/common/defaults/main.yml

- name: Patch | Get the highest version number from gi_patches array
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: patch should be lowercase

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

patch.yml Outdated
- include_role:
name: patch
tasks_from: patch_vars.yml
tags: populate_variables
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Call it patch_vars for consistency maybe? I'll have a related comment inside patch_vars.yml

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

roles/patch/tasks/patch_vars.yml Show resolved Hide resolved
Copy link
Member

@mfielding mfielding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

@jcnars jcnars merged commit eb4587a into master Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants