-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
host provision config tasks that follow initial connection setup #89
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the delayed reply here.
username: "{{ rhel_username }}" | ||
password: "{{ rhel_password }}" | ||
auto_attach: true | ||
# we ignore when: "This system is already registered" is in the output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please only ignore "This system is already registered" errors? I'd imagine that many other error cases would warrant issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modifying the logic for this completely. The new logic (when I push my branch) will reside in: bms-toolkit/roles/host-provision/tasks/rhel-config-tasks.yml
.
In essence the logic will:
- Get current registration status of the host
- If host is not 'Subscribed':
* ask Redhat Support username/password on the cmd line
* Register host in RHSM
With this, we don't have to ignore any errors.
https://paste.googleplex.com/6592815808118784 (internal) shows successful runs after code modification with different input options. Here is the codeflow schematic for ref: |
Incorporated changes. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcnars The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcnars, mfielding The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Post the user creation in the previous PR, extending the previously merged code with additional functionality in this PR.
Command called as: