Adding OWNERS file #91
Conversation
There was a problem hiding this comment.
@jcnars: 1 invalid OWNERS file
In response to this:
As expected by OSS bot, adding OWNERS file:
#90 (comment)
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
OWNERS
Outdated
| @@ -0,0 +1,3 @@ | |||
| mfielding | |||
There was a problem hiding this comment.
Cannot parse file: error unmarshaling JSON: while decoding JSON: json: cannot unmarshal string into Go value of type repoowners.FullConfig.
There was a problem hiding this comment.
This is fixed. Changed from:
mfielding
rachelhmyang
jcnars
to:
approvers:
- mfielding
- jcnars
- rachelhmyang
There was a problem hiding this comment.
You may need to disable the OSS robot o get this submitted, as there are no current approvers.
This involves a fairly big (but fortunately mostly self-documenting) process for reviews; it might make sense to annotate docs/contributing.md appropriately, as it's different form the traditional GitHub process many may be familiar with.
| @@ -0,0 +1,4 @@ | |||
| approvers: | |||
There was a problem hiding this comment.
Can you add a comment referencing context? A suggestion:
bms-toolkit leverages the Kubernetes project's owner convention https://go.k8s.io/owners
IIUC, this is only true if we using the bot to merge the PR, which in our case is not. We will see shortly when we merge this !
Agreed, adding the link you mentioned in the other comment. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jcnars, mfielding The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
As expected by OSS bot, adding OWNERS file:
#90 (comment)