Skip to content

Commit

Permalink
Revert "Reland "Revert "Add other Windows configurations to the CQ."""
Browse files Browse the repository at this point in the history
This reverts commit 43eb0af.

Reason for revert: Hopefully this is resolved by https://boringssl.googlesource.com/boringssl/+/7c8e725e55a72c914eb3a33af6cc65b4188102c6 ?

Original change's description:
> Reland "Revert "Add other Windows configurations to the CQ.""
> 
> This reverts commit 23e92d5.
> 
> Reason for revert: Nope. Still doesn't work. Back to poking infra
> about it...
> 
> Original change's description:
> > Revert "Revert "Add other Windows configurations to the CQ.""
> > 
> > This reverts commit 9883173.
> > 
> > Let's try this again. tandrii@ says this should be resolved as of
> > https://crbug.com/840505. (That was a while ago. I'd forgotten about
> > it.)
> > 
> > Change-Id: Ib49a629198a33d44ff1c3aa13af5825def1a5c4d
> > Reviewed-on: https://boringssl-review.googlesource.com/28924
> > Reviewed-by: Steven Valdez <svaldez@google.com>
> > Commit-Queue: Steven Valdez <svaldez@google.com>
> > CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>
> 
> TBR=davidben@google.com,svaldez@google.com
> 
> Change-Id: Iecd0710075f1fedc4dea69283d018042fb1a2490
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://boringssl-review.googlesource.com/29104
> Commit-Queue: David Benjamin <davidben@google.com>
> Reviewed-by: David Benjamin <davidben@google.com>
> CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>

TBR=davidben@google.com,svaldez@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I583641be42e6e6e93eb30adbe56ae20812608103
Reviewed-on: https://boringssl-review.googlesource.com/29184
Reviewed-by: David Benjamin <davidben@google.com>
  • Loading branch information
davidben committed Jun 14, 2018
1 parent 23aa4d2 commit 9f9c938
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion infra/config/cq.cfg
Expand Up @@ -53,7 +53,10 @@ verifiers {
builders { name: "win64" }
builders { name: "win64_rel" }
builders { name: "win64_small" }

builders { name: "win32_vs2017_compile" }
builders { name: "win64_vs2017_compile" }
builders { name: "win32_clang_vs2017_compile" }
builders { name: "win64_clang_vs2017_compile" }

builders { name: "linux_fips" }
builders { name: "linux_fips_rel" }
Expand Down

0 comments on commit 9f9c938

Please sign in to comment.