Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different dictionary.h files? #151

Closed
ericlaw1979 opened this issue Sep 8, 2015 · 2 comments
Closed

Different dictionary.h files? #151

ericlaw1979 opened this issue Sep 8, 2015 · 2 comments

Comments

@ericlaw1979
Copy link

Shouldn't \dec\dictionary.h and \enc\dictionary.h be identical?

https://github.com/google/brotli/blob/master/enc/dictionary.h looks like it may be out-of-date; it doesn't include, e.g. the

#if defined(__cplusplus) || defined(c_plusplus)
}    /* extern "C" */
#endif

...block at the end, for instance.

(Incidentally, declaration of the constant in a header file is apparently frowned upon per people smarter than me. Naively building brotli.exe with VS2015 results in 6 copies of the constant array in the resulting executable.)

@lvandeve
Copy link
Contributor

Thank you for reporting this. We'll fix it soon.

@szabadka
Copy link
Collaborator

szabadka commented Oct 1, 2015

This is fixed in PR #187

@szabadka szabadka closed this as completed Oct 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants