Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indentical header names, different contents #181

Closed
bagder opened this issue Sep 27, 2015 · 1 comment
Closed

Indentical header names, different contents #181

bagder opened this issue Sep 27, 2015 · 1 comment

Comments

@bagder
Copy link

bagder commented Sep 27, 2015

Hey, issue #151 mentions how dictionary.h exists in two versions in enc/ and dec/ while they perhaps should be identical.

What about other headers like streams.h that exist in both directories but are very different?

I've been putting together a little build setup that creates a libbrotli so that we can write test applications easier against the brotli code and when we install the public headers I would like to put them into the same directory (under brotli/) mostly since using more than one slash for a public header for a library is quite unusual for C and C++ programs.

As I suspect you too might want to do this at some point, or just help my project function, I figure it could be an idea to consider having different headers use different file names even when they are in a different directory in your source tree.

@bagder
Copy link
Author

bagder commented Sep 29, 2015

We decided having them as two libs might be the best way forward, so having the files in separate directories then became less of an issue...

@bagder bagder closed this as completed Sep 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant