New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for future versions of setuptools #911
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
✅ Build brotli 1.0.0#1625 completed (commit 52a92b214c by @scardracs) |
@dlemstra i see you are the latest one that committed inside this repo. Could you tell me who is the right person to ask for merge? Or could you merge it? |
You can check the pull request that is referenced in my commit and see who made the merge. |
@scardracs it appears you need to sign the CLA @eustas or anyone else, can this please be merged? |
@candrews sorry for late answer, it seems no one take a look into it |
You will need to sign the CLA @scardracs. |
@googlebot I signed it! |
Can this PR now be merged? |
Hello. Sorry for super-late reply. One question - what will happen with PY2 builds? |
Please rebase as well. |
I haven't tested against py2 as it should be EOL. |
@anthrotype WDYT? |
Starting python 3.10, the use of - instead of _ will get a warn (see https://bugs.gentoo.org/796281 for reference) Signed-off-by: Marco Scardovi <marco@scardovi.com>
@eustas rebased |
@scardracs thanks. Still waiting for opinion from @anthrotype. |
I have no problem on waiting :) |
News? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, sorry for the delay in responding
Starting python 3.10, the use of - instead of _ will get a warn (see https://bugs.gentoo.org/796281 for reference) Signed-off-by: Marco Scardovi <marco@scardovi.com>
Starting python 3.10, the use of - instead of _ will get a warn (see https://bugs.gentoo.org/796281 for reference)
Signed-off-by: Marco Scardovi marco@scardovi.com