Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for future versions of setuptools #911

Merged
merged 1 commit into from Jan 10, 2022
Merged

Fix for future versions of setuptools #911

merged 1 commit into from Jan 10, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jul 4, 2021

Starting python 3.10, the use of - instead of _ will get a warn (see https://bugs.gentoo.org/796281 for reference)

Signed-off-by: Marco Scardovi marco@scardovi.com

@google-cla
Copy link

google-cla bot commented Jul 4, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@ghost ghost changed the title Fix for future versions of python Fix for future versions of setuptools Jul 4, 2021
@AppVeyorBot
Copy link

@ghost
Copy link
Author

ghost commented Jul 14, 2021

@dlemstra i see you are the latest one that committed inside this repo. Could you tell me who is the right person to ask for merge? Or could you merge it?

@dlemstra
Copy link
Contributor

dlemstra commented Jul 14, 2021

You can check the pull request that is referenced in my commit and see who made the merge.

@ghost
Copy link
Author

ghost commented Jul 14, 2021

@dlemstra thanks :) @eustas can you take a look on my PR?

@candrews
Copy link

@scardracs it appears you need to sign the CLA

@eustas or anyone else, can this please be merged?

@ghost
Copy link
Author

ghost commented Nov 20, 2021

@candrews sorry for late answer, it seems no one take a look into it

@dlemstra
Copy link
Contributor

You will need to sign the CLA @scardracs.

@ghost
Copy link
Author

ghost commented Nov 27, 2021

@googlebot I signed it!

@candrews
Copy link

candrews commented Dec 8, 2021

Can this PR now be merged?

@eustas
Copy link
Collaborator

eustas commented Dec 15, 2021

Hello.

Sorry for super-late reply.

One question - what will happen with PY2 builds?

@eustas
Copy link
Collaborator

eustas commented Dec 15, 2021

Please rebase as well.

@ghost
Copy link
Author

ghost commented Dec 15, 2021

Please rebase as well.

I haven't tested against py2 as it should be EOL.

@eustas
Copy link
Collaborator

eustas commented Dec 15, 2021

@anthrotype WDYT?

Starting python 3.10, the use of - instead of _ will get a warn (see https://bugs.gentoo.org/796281 for reference)

Signed-off-by: Marco Scardovi <marco@scardovi.com>
@ghost
Copy link
Author

ghost commented Dec 15, 2021

@eustas rebased

@eustas
Copy link
Collaborator

eustas commented Dec 20, 2021

@scardracs thanks. Still waiting for opinion from @anthrotype.
As I can see we don't build for PY2 in https://github.com/google/brotli-wheels
So, most likely this change is fine.

@ghost
Copy link
Author

ghost commented Dec 20, 2021

@scardracs thanks. Still waiting for opinion from @anthrotype. As I can see we don't build for PY2 in https://github.com/google/brotli-wheels So, most likely this change is fine.

I have no problem on waiting :)

@ghost
Copy link
Author

ghost commented Jan 7, 2022

News?

Copy link
Member

@anthrotype anthrotype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for the delay in responding

@eustas eustas merged commit f4153a0 into google:master Jan 10, 2022
juj pushed a commit to Unity-Technologies/brotli that referenced this pull request May 13, 2023
Starting python 3.10, the use of - instead of _ will get a warn (see https://bugs.gentoo.org/796281 for reference)

Signed-off-by: Marco Scardovi <marco@scardovi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants