--lang option
#55
Merged
--lang option
#55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tushuhei
requested changes
Apr 4, 2022
.gitignore
Outdated
| @@ -6,6 +6,9 @@ __pycache__ | |||
| *.pyc | |||
| *.log | |||
| *.egg-info | |||
| *,cover | |||
There was a problem hiding this comment.
Maybe this comma should be a dot instead.
There was a problem hiding this comment.
When I executed pytest --cov-report annotate, somehow *,cover files were generated. But it is not generated when I run it now. So I'll delete this.
README.md
Outdated
| 本日は | ||
| 晴天です。 | ||
|
|
||
| $ budoux -l zh 今天天气晴朗。 |
There was a problem hiding this comment.
Actually, I want to use zh-hans as the language code because I would like to emphasize that this is for Simplified Chinese (hans), not for Traditional Chinese (hant) here.
README.md
Outdated
| -h, --help show this help message and exit | ||
| -H, --html HTML mode (default: False) | ||
| -m JSON, --model JSON custom model file path (default: /path/to/models/ja-knbc.json) | ||
| -m JSON, --model JSON custom model file path (default: /home/eggplants/prog/budoux/budoux/models/ja-knbc.json) |
There was a problem hiding this comment.
Probably we may want to generalize the default model path.
README.md
Outdated
| -d STR, --delim STR output delimiter in TEXT mode (default: ---) | ||
| -t THRES, --thres THRES threshold value to separate chunks (default: 1000) | ||
| -V, --version show program's version number and exit | ||
|
|
||
| supported languages of `-l`, `--lang`: | ||
| - zh |
There was a problem hiding this comment.
I would like to use zh-hans here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added
-l,--langoption to select a model by a language code.