Fix deserialization codegen with manually implemented builder. #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmorgan
force-pushed
the
fix-manual-builder-deserialization
branch
4 times, most recently
from
c724174
to
b650c21
Compare
|
LG |
davidmorgan
force-pushed
the
fix-manual-builder-deserialization
branch
2 times, most recently
from
f270b92
to
37d94fb
Compare
The generated code now checks at runtime if the builder method auto-instantiated the nested builder. Add `FieldMixin` to reuse code between value generator and serializer generator.
davidmorgan
force-pushed
the
fix-manual-builder-deserialization
branch
from
37d94fb
to
7613eb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.