Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UUID byte-order in serialization #132

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Fix UUID byte-order in serialization #132

merged 1 commit into from
Mar 3, 2023

Conversation

rahularya50
Copy link
Contributor

No description provided.

barbibulle
barbibulle reviewed Mar 2, 2023
View reviewed changes
Copy link
Collaborator

@barbibulle barbibulle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I can't believe we have not run into this bug before!

bumble/core.py Outdated Show resolved Hide resolved
bumble/core.py Outdated Show resolved Hide resolved
@rahularya50 rahularya50 requested review from barbibulle and uael and removed request for barbibulle and uael March 3, 2023 22:10
@rahularya50
Copy link
Contributor Author

I can't submit this, since I don't have write access. Would one of you mind doing so? Thanks

@uael uael merged commit ca063ed into google:main Mar 3, 2023
@rahularya50 rahularya50 deleted the aryarahul/fix-uuid branch March 3, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barbibulle barbibulle barbibulle approved these changes

@uael uael uael approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rahularya50 @barbibulle @uael