Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ATT permissions on server-side #138

Merged
merged 1 commit into from
Mar 4, 2023
Merged

Add support for ATT permissions on server-side #138

merged 1 commit into from
Mar 4, 2023

Conversation

rahularya50
Copy link
Contributor

No description provided.

barbibulle
barbibulle reviewed Mar 3, 2023
View reviewed changes
Copy link
Collaborator

@barbibulle barbibulle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Please just check the formatter (use invoke project.pre-commit to check, or see the GH actions output, and invoke project.format to run the formatter)

bumble/gatt_server.py Outdated Show resolved Hide resolved
uael
uael reviewed Mar 4, 2023
View reviewed changes
bumble/att.py Outdated Show resolved Hide resolved
bumble/gatt_server.py Show resolved Hide resolved
@rahularya50 rahularya50 requested review from uael and removed request for barbibulle March 4, 2023 00:11
@uael uael merged commit 46e7aac into google:main Mar 4, 2023
@rahularya50 rahularya50 deleted the aryarahul/fix-att-perms branch March 4, 2023 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barbibulle barbibulle barbibulle left review comments

@uael uael uael approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rahularya50 @barbibulle @uael