add benchmark tool and doc #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uael
approved these changes
Mar 21, 2023
apps/bench.py
Outdated
| self.expected_packet_index = packet_index + 1 | ||
|
|
||
| if packet_flags & PACKET_FLAG_LAST: | ||
| asyncio.create_task( |
There was a problem hiding this comment.
Because of python/cpython#88831, I suggest to push the packet to a queue and to loop get/send in // of self.done.wait() in async def run(self) bellow
There was a problem hiding this comment.
Oh! I wasn't aware of that. I have to go and check that we don't have this potential issue elsewhere in the code base.
There was a problem hiding this comment.
Fixed in latest commit.
There was a problem hiding this comment.
I just thought about that but we can call it spawn instead of run?
Edit: not this one, I mean the new one in AsyncRunner
There was a problem hiding this comment.
Yes, good point, spawn is a better name for it.
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a "swiss army knife" benchmarking tool that can be used to test the throughput and/or latency between two devices.
Supported modes:
Supported roles:
One device runs as the Central (with the ability to specify a custom Connection Interval and PHY), the other as the Peripheral.
The modes are independent of the roles and of the central/peripheral choice. So, for example, you can have a Central be a Sender as a GATT client (default), and the Peripheral be the Receiver as a GATT server. But you could also have the Central be a Receiver as a GATT client, or a Sender as a GATT server, etc.