New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use device public or static address for keystore namespace #171

Merged

barbibulle merged 2 commits into main from gbg/keystore-name

Apr 4, 2023

Collaborator

barbibulle commented Apr 3, 2023

Instead of just using the device static random address, use the most likely identifier for the controller as the namespace for keystores:

Try the public address first if the controller has one
Second choice is the static random address assigned to the controller
Otherwise: default namespace.


          use device public or static address for keystore namespace

fca73a4

barbibulle requested a review from uael

April 3, 2023 19:41

uael approved these changes

View reviewed changes

Contributor

uael left a comment

lgtm 👍


          only instantiate keystore if not already set

620c135

barbibulle merged commit c53e1d2 into main

7 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment