Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only use 1M parameters by default #176

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Conversation

barbibulle
Copy link
Collaborator

Some controllers, like Zephyr-based controllers, don't like it when passing multiple connection parameters in the connection request (even if the PHY is supported). For example, with a Zephyr controller (from the Zephyr HCI USB example), when not specifying explicit parameters in the connection request (which is what most of the tools and examples do), this would lead
to the controller returning HCI_UNSUPPORTED_FEATURE_OR_PARAMETER_VALUE_ERROR.
This change is for only specifying default values for 1M if no explicit preferences are passed (you can still pass arbitrary sets if you want, this only changes the default). It also seems reasonable to pick only 1M by default, since that's the expected baseline for all controllers.

@barbibulle barbibulle requested a review from uael April 10, 2023 01:01
@barbibulle barbibulle merged commit 5351ab8 into main Apr 12, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants