Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin aiohttp at version 3.8 #201

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Pin aiohttp at version 3.8 #201

merged 1 commit into from
Jun 14, 2023

Conversation

benquike
Copy link
Contributor

Recently aiohttp package is upgraded to 4.0.x version, which breaks setup.py. This change fix the build issue by pinning it at version 3.8.4.

@uael uael requested a review from barbibulle June 13, 2023 02:32
@barbibulle
Copy link
Collaborator

Tight pinning isn’t ideal for downstream users. If 4.x creates an issue, I recommend specifying: either just ~= 3.8 or >= 3.8.4, = 4.*

Recently aiohttp package is upgraded to 4.0.x version,
which breaks setup.py. This change fix the build issue
by pinning it at version 3.8.4.
@benquike benquike changed the title Pin aiohttp at version 3.8.4 Pin aiohttp at version 3.8 Jun 14, 2023
@barbibulle barbibulle merged commit e9dc0d6 into google:main Jun 14, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants