Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compatibility with python 11 #227

Merged
merged 2 commits into from
Jul 28, 2023
Merged

compatibility with python 11 #227

merged 2 commits into from
Jul 28, 2023

Conversation

barbibulle
Copy link
Collaborator

Python 11's handling of enums has changed a bit, so the conversion to string behaves differently from before.
This should make the code and type checking compatible with the new modes.

@barbibulle
Copy link
Collaborator Author

This breaks python < 11, I will push an update.

Copy link
Collaborator

@zxzxwu zxzxwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@uael uael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not tested in AOSP yet but it should work! If any issues is encountered we can still fixes in follow up PR

@barbibulle barbibulle merged commit a0a4bd4 into main Jul 28, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants