Faster company id table #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barbibulle
approved these changes
Aug 4, 2023
marshallpierce
force-pushed
the
mp/company-ids
branch
from
4a0a440
to
dae7d84
Compare
Following up on the [loose end from the initial PR](google#207 (comment)), we can avoid accessing the Python company id map at runtime by doing code gen ahead of time. Using an example to do the code gen avoids even the small build slowdown from invoking the code gen logic in build.rs, but more importantly, means that it's still a totally boring normal build that won't require any IDE setup, etc, to work for everyone. Since the company ID list changes rarely, and there's a test to ensure it always matches, this seems like a good trade.
marshallpierce
force-pushed
the
mp/company-ids
branch
from
dae7d84
to
e2c1ad5
Compare
nabilwadih
approved these changes
Aug 8, 2023
whitevegagabriel
approved these changes
Aug 8, 2023
|
Do you think it's worth generating an enum and impl Display? |
|
Or using a static array instead? As it looks like indexes are sequential |
|
I'm not familiar enough with the ways of the Bluetooth SIG to know if counting on them being sequential, and complete, is reasonable. Maybe? 🤷 We certainly could make an enum. I'm not sure what the use case would be, but that could be a lack of imagination on my end. Do you have something in mind? Presumably, some code that wants to refer to, say, |
|
Ok SGTM I was just wondering 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on the loose end from the initial PR, we can avoid accessing the Python company id map at runtime by doing code gen ahead of time.
Using an example to do the code gen avoids even the small build slowdown from invoking the code gen logic in build.rs, but more importantly, means that it's still a totally boring normal build that won't require any IDE setup, etc, to work for everyone. Since the company ID list changes rarely, and there's a test to ensure it always matches, this seems like a good trade.