Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring HfpProtocol back #272

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Bring HfpProtocol back #272

merged 2 commits into from
Sep 7, 2023

Conversation

zxzxwu
Copy link
Collaborator

@zxzxwu zxzxwu commented Sep 7, 2023

There are still many users using the original protocols. Though we are still in an early stage, deprecation should be slowly and responsible. Also, there is no alternative for AG and low-level usage.

barbibulle
barbibulle approved these changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@barbibulle barbibulle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good to have a way to support the AG mode. I think we should try to merge the lower-level functionalities of HfpProtocol in a way that can be shared with the HfProtocol class here, in a future PR.

hchataing
hchataing approved these changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@hchataing hchataing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was planning on working on the AG side as well by have been delayed by other tasks ...

@zxzxwu
Copy link
Collaborator Author

zxzxwu commented Sep 7, 2023 •
edited

Yes, from my perspective HfProtocol is more like a servicer above the protocol. Though I marked the protocol deprecate here, I would prefer HF&AG wrappers working over HfpProtocol, and leave this class as a base or for those who want to access the HFP text directly.

@barbibulle barbibulle merged commit d292083 into google:main Sep 7, 2023
16 checks passed
@zxzxwu zxzxwu deleted the gfp branch December 2, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barbibulle barbibulle barbibulle approved these changes

@hchataing hchataing hchataing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zxzxwu @barbibulle @hchataing