use Address.to_string instead of manual suffix replacement #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uael
approved these changes
Sep 27, 2023
apps/console.py
Outdated
| @@ -1172,7 +1172,7 @@ def to_display_string(self): | |||
| name = '' | |||
|
|
|||
| # Remove any '/P' qualifier suffix from the address string | |||
| address_str = str(self.address).replace('/P', '') | |||
| address_str = self.address.to_string(False) | |||
There was a problem hiding this comment.
it's not obvious by reading this LOC what False is referring to. is that param required or could we change it to optional?
There was a problem hiding this comment.
This param is with_type_qualifier, it is already optional, in the sense that it has a default value (True). To make it clearer, I'll update this call to say to_string(with_type_qualifier=False) explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.