CIS and SCO responder support #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zxzxwu
force-pushed
the
cis
branch
5 times, most recently
from
34c53d2
to
46a0224
Compare
16 tasks
barbibulle
reviewed
Nov 28, 2023
bumble/host.py
Outdated
| if event.status == HCI_SUCCESS: | ||
| self.emit('cis_established', event.connection_handle) | ||
| else: | ||
| self.emit('cis_established_failure', event.connection_handle, event.status) |
There was a problem hiding this comment.
I think cis_establishment_failure would be a better name for this.
zxzxwu
force-pushed
the
cis
branch
4 times, most recently
from
3f84822
to
d889ad5
Compare
barbibulle
approved these changes
Nov 29, 2023
|
I found I added too much SCO item in this PR which makes it pretty big, so I decide to merge this PR first and then improve the SCO support in another PR. TODO for SCO:
|
zxzxwu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.