extended advertising v2 #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barbibulle
force-pushed
the
gbg/extended-advertising-v2
branch
from
8a8f3ba
to
0697723
Compare
barbibulle
force-pushed
the
gbg/extended-advertising-v2
branch
from
0697723
to
cb17f3b
Compare
zxzxwu
reviewed
Jan 14, 2024
bumble/host.py
Outdated
Comment on lines
50
to
51
| HCI_INQUIRY_COMPLETE_EVENT, | ||
| HCI_INQUIRY_RESULT_EVENT, |
There was a problem hiding this comment.
Including so many items does raise my concern. It also violates Google's Python Style Guide(though it's also not compatible with Black style, and we never follow it from the beginning).
I think we may import hci module here, and add a nick name without HCI_ prefix if we want to avoid repeated HCI at each line.
There was a problem hiding this comment.
You're right, the list is becoming too long. I'll make the change here to just import hci and use hci.XXX in this file. Eventually, I'll try to push a PR later on to do the same change in other files that also import too many symbols directly. It will make the lines a bit longer, but I think it's a cleaner model.
zxzxwu
reviewed
Jan 14, 2024
barbibulle
force-pushed
the
gbg/extended-advertising-v2
branch
from
1e3785a
to
8d2f37a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an enhanced API for extended advertising which allows:
1/ using extended advertising commands for legacy advertising (keeping the original advertising API as-is)
2/ creating advertising set objects, which can be independently started/stopped/updated, using a new API.
The new/extended API also allows creating advertisements with legacy PDUs (very typical when you want to be compatible with older devices/phones) in addition to newer ones.
The unit tests aren't complete yet, because they will be easier to write once we merge the PR with basic support for extended advertising in the local controller class. Using Host mocks isn't a great way to test, because you need the full logic of a Controller to ensure that the sequence of events (for example, you need responses for some commands, not just mocking accepting a command and mocking some events), as well as the declared/supported properties, behave correctly.
A future PR will also include a way to test with Root Canal, when available (only on some platforms), but that's out of scope for this PR.