LE read remote features #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zxzxwu
force-pushed
the
remote_feature
branch
3 times, most recently
from
aa190d5
to
a2025bb
Compare
|
BTW, why we need this feature is because sending LE data without performing feature/version exchange is very easy to fail (on the first packet). |
barbibulle
reviewed
Jan 4, 2024
zxzxwu
force-pushed
the
remote_feature
branch
2 times, most recently
from
0c7c774
to
ca53737
Compare
barbibulle
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we can share BR/EDR and LE behavior in the same function. However, BR/EDR type is a little bit complicated(3+1 pages), so returning them might not be so useful.