Add RFCOMM and SDP context manager and search helper #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
zxzxwu
commented
Feb 2, 2024
•
zxzxwu
commented
- Add an RFCOMM (Client, Server) and SDP(Client only because Server is managed by device) context manager.
- Add an RFCOMM helper function to search channel from SDP.
- And some test cases.
zxzxwu
changed the title
zxzxwu
force-pushed
the
rfc
branch
3 times, most recently
from
704db9f
to
e635902
Compare
barbibulle
reviewed
Feb 2, 2024
bumble/rfcomm.py
Outdated
| ) | ||
| ) | ||
|
|
||
| return records | ||
|
|
||
|
|
||
| # ----------------------------------------------------------------------------- | ||
| async def search_channels_from_sdp(connection: Connection) -> Dict[int, List[UUID]]: |
There was a problem hiding this comment.
There's a similar helper in bench.py. The other one doesn't return a list, but looks just for one specific UUID. I think both are useful.
Maybe the single-uuid version from bench.py could be re-written by using this one, and moved to rfcomm.py.
We'd end up with:
rfcomm.find_rfcomm_channels(this one, just different name) andrfcomm.find_rfcomm_channel_with_uuid(the refactored one moved over frombench.py)
There was a problem hiding this comment.
I was wondering whether it should be a directional search or general search, but it seems not bad to have both.
zxzxwu
force-pushed
the
rfc
branch
2 times, most recently
from
4b6159a
to
95d1a6d
Compare
barbibulle
reviewed
Feb 2, 2024
|
|
||
|
|
||
| # ----------------------------------------------------------------------------- | ||
| async def find_rfcomm_channel_with_uuid( |
There was a problem hiding this comment.
That function could be implemented by calling the generic find functions, then looking for the UUID in the resulting dict (less duplicated code)
barbibulle
approved these changes
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.