Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HFP AG implementation #465

Merged
merged 1 commit into from Apr 12, 2024
Merged

HFP AG implementation #465

merged 1 commit into from Apr 12, 2024

Conversation

zxzxwu
Copy link
Collaborator

@zxzxwu zxzxwu commented Apr 8, 2024 •
edited

  • Implement AG implementation including features:
    • SLC setup
    • AG indicator
    • HF indicator
    • Dial, Answer, Hang up
    • Codec negotiation
    • SDP record builder
    • Rename hfp.Configuration => hfp.HfConfiguration to be more clear.
  • Add HFP self tests
  • Fix HF errors in pre-3.10
  • Implement HFP SDP record discovery

@zxzxwu zxzxwu closed this Apr 9, 2024
@zxzxwu zxzxwu reopened this Apr 9, 2024
@zxzxwu zxzxwu force-pushed the hfp-ag branch 5 times, most recently from 51900dc to 67e729c Compare April 9, 2024 09:12
@zxzxwu
Copy link
Collaborator Author

zxzxwu commented Apr 9, 2024

I will implement the remaining features and web-based example in future PRs.

@zxzxwu zxzxwu requested review from hchataing and barbibulle and removed request for hchataing April 9, 2024 09:22
@zxzxwu zxzxwu changed the title [WIP] HFP AG implementation HFP AG implementation Apr 9, 2024
@zxzxwu zxzxwu marked this pull request as ready for review April 9, 2024 09:25
@zxzxwu zxzxwu force-pushed the hfp-ag branch 2 times, most recently from acf6e3b to 4483819 Compare April 10, 2024 06:41
barbibulle
barbibulle approved these changes Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@barbibulle barbibulle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Would like to get @hchataing's review on this as well.

hchataing
hchataing approved these changes Apr 11, 2024
View reviewed changes
bumble/hfp.py Show resolved Hide resolved
@zxzxwu zxzxwu merged commit 8758856 into google:main Apr 12, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barbibulle barbibulle barbibulle approved these changes

@hchataing hchataing hchataing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zxzxwu @barbibulle @hchataing