support out of order advertising set termination / connection events #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zxzxwu
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Would be nice to have a test for it
like https://github.com/google/bumble/blob/f910a696ad5d286201d40480398393b1e9bf5237/tests/device_test.py#L362C11-L362C47
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some controllers (like the ASUS BT500) send the advertising set termination event before the connection complete event. At that time, the Connection object for connection_handle in the event isn't yet known. When that happens, we need to support remembering the address information until the connection complete event arrives.