Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Device improvements #55

Merged
merged 13 commits into from
Nov 7, 2022
Merged

Device improvements #55

merged 13 commits into from
Nov 7, 2022

Conversation

uael
Copy link
Contributor

@uael uael commented Oct 24, 2022 •
edited

See commits for details.

@uael uael requested review from barbibulle and 8lank October 24, 2022 22:45
@uael uael requested review from barbibulle and removed request for barbibulle October 31, 2022 16:47
barbibulle
barbibulle approved these changes Nov 2, 2022
View reviewed changes
bumble/device.py Outdated Show resolved Hide resolved
bumble/device.py Outdated Show resolved Hide resolved
bumble/device.py Show resolved Hide resolved
@uael uael force-pushed the uael/device-improvements branch 2 times, most recently from b9d9e33 to 527f815 Compare November 2, 2022 18:00
@uael uael mentioned this pull request Nov 2, 2022
Open
@uael
host: allow bytes return paramaters when checking command result
65deefd
@uael
host: pass remote_host_supported_features event to upper layer
8119bc2 
The `HCI_Remote_Name_Request` command may trigger this HCI event.
Instead of warn for not being handled, pass it to upper layer.
@uael uael requested a review from barbibulle November 2, 2022 20:24
uael
uael commented Nov 3, 2022
View reviewed changes
bumble/device.py Outdated Show resolved Hide resolved
bumble/device.py Outdated Show resolved Hide resolved
@uael uael marked this pull request as draft November 3, 2022 02:41
@uael uael force-pushed the uael/device-improvements branch 2 times, most recently from 5986d1c to dc2455c Compare November 3, 2022 15:37
@uael uael marked this pull request as ready for review November 3, 2022 15:43
@uael
core: improve Advertisement.ad_data_to_object with support for more…
fc331b7 
… data types
@uael
core: change AdvertisingData.get default raw behavior to False
ce9472b
@uael
device: enhance .request_remote_name to also accept an Address as…
78534b6 
… argument
@uael
device: add auto_restart mechanism to .start_discovery (default t…
51ddb36 
…o `True`)
@uael
device: update Device.connect documentation to match BR/EDR behavior
b961aff
@uael
le: make the device connecting state relative to LE only
e9e14f5 
We may need to add a distinct BR/EDR connecting state in the future.
@uael
le: add own_address_type parameter to Device.start_advertising
ca8f284
@uael
classic: upgrade Device.cancel_connection logic to support cancelin…
7044102 
…g ongoing BR/EDR connections
@uael
classic: add BR/EDR accept connection logic
56ed46a
@uael uael merged commit be8f8ac into main Nov 7, 2022
@uael uael deleted the uael/device-improvements branch November 7, 2022 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barbibulle barbibulle barbibulle approved these changes

@8lank 8lank 8lank approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@uael @barbibulle @8lank