Pairing improvements #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barbibulle
approved these changes
Nov 10, 2022
|
the change makes sense, but it looks like the tests need to be fixed/changed as well. |
uael
force-pushed
the
uael/pairing-improvements
branch
from
9fc5da3
to
8bbba7c
Compare
…se the right self address
uael
commented
Nov 10, 2022
Yes I just fixed :) I had to add a new logic for this reason: I think the change is "good-enough" for now, but it's kind of a hack, you may have a better solution |
uael
changed the title
JUST_WORKS method
Yes, this works well enough for now. We can revisit it later when we implement extended advertising. |
barbibulle
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.