OOM detection logic doesn't work inside a docker container.

[vishh]

Also, after the recent changes, did we test if OOM detection works without journalctl command available?

cc @timstclair

We might have to fix this for k8s v1.3

[luxas]

(Just a small note, I don't think the case was inside a container, it was in the localkube vm)
But it might be a bug nonetheless. At least it's confusing in case it's not required

[vishh]

I tried a docker container and it did not work inside the container either!

On Fri, May 27, 2016 at 9:33 AM, Lucas Käldström notifications@github.com
wrote:

(Just a small note, I don't think the case was inside a container, it was
in the localkube vm)
But it might be a bug nonetheless. At least it's confusing in case it's
not required

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1313 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AGvIKMuoI9DBKf9SxgNLJYDNIhURtwqmks5qFxzkgaJpZM4IonQd
.

[luxas]

Any clue how to solve?

[vishh]

I think cAdvisor is not looking at the relative root path while inside the
container. On the outside, I suspect that not finding journalctl binary
is the cause of the failure.

On Fri, May 27, 2016 at 10:23 AM, Lucas Käldström notifications@github.com
wrote:

Any clue how to solve?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1313 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AGvIKPEG5M_3dC_OlyyqsVkQ2ODg7xrAks5qFyh3gaJpZM4IonQd
.

[luxas]

@vishh @timstclair Will this be fixed before v1.3?

[vishh]

cAdvisor from HEAD works fine from outside the container. I haven't gotten around to test it inside a container yet.

[goettl79]

Testet it with cadvios 0.24.1 by mounting the journalctl binary into the container like this:

--volume=/usr/bin/journalctl:/usr/bin/journalctl:ro

This change makes the oom parser at least start:

manager.go:1082] Started watching for new ooms in manager

However, the shared libraries for journalctl as well as the journalctl data is missing inside the container. I'd suggest to install journalctl in the cadvisor image and actually change the logic that determines if journalctl or syslog is used. My proposal is to change it based on program arguments, not on existence of the journalctl binary.

[vishh]

cAdvisor is used as a library as well. So we need to be careful while adding external dependencies.

…

On Mon, Jan 9, 2017 at 5:10 AM, goettl79 ***@***.***> wrote: testet it, mounting the binary with --volume=/usr/bin/journalctl:/usr/bin/journalctl:ro \ makes the oom parser at least start manager.go:1082] Started watching for new ooms in manager however the shared libraries for journalctl as well as the data is missing inside the container. I'd suggest to install journalctl in the cadvisor image and actually change the logic based on programm arguments, not on existence of a binary ... — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1313 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGvIKK4HpoWlZxhCeeuxlOpW--hudwuVks5rQjHMgaJpZM4IonQd> .

[goettl79]

I think this would not be a dependency to cadvisor, rather a change in the dockerfile.

[vishh]

My point is that Dockerfile is an optional deployment model. cAdvisor can run outside of Docker too.

…

On Mon, Jan 9, 2017 at 10:06 AM, goettl79 ***@***.***> wrote: I think this would not be a dependency to cadvisor, rather a change in the dockerfile. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1313 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGvIKJjVLm5By6zz39HiZLKUJvqGsxetks5rQncegaJpZM4IonQd> .