Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rip out basic auth #1621

Open
timstclair opened this issue Mar 17, 2017 · 3 comments
Open

Rip out basic auth #1621

timstclair opened this issue Mar 17, 2017 · 3 comments

Comments

@timstclair
Copy link
Contributor

cAdvisors authentication is not implemented correctly, and in it's current state is worse than no auth (can give a false sense of security). The obvious problem is that only some of the endpoints are actually authenticated, but the same information can be accessed from an unauthenticated endpoint. There are also issues with error handling, and possible non-enforcement issues (#1554).

I think we should just remove auth entirely for now. Users who require auth can set it up using an nginx proxy.

/cc @vishh @dashpole

@vishh
Copy link
Contributor

vishh commented Mar 17, 2017 via email

@ghost
Copy link

ghost commented Feb 10, 2022

is this still current and correct information?

if so, this part should probably also be removed from the docs?

https://github.com/google/cadvisor/blob/master/docs/web.md#web-ui-authentication

@pikhovkin
Copy link

This issue is still actual. #3060, #2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants