Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod/go.sum/vendor directory are out of date for 0.36.0. #2453

Closed
williamh opened this issue Mar 26, 2020 · 4 comments
Closed

go.mod/go.sum/vendor directory are out of date for 0.36.0. #2453

williamh opened this issue Mar 26, 2020 · 4 comments

Comments

@williamh
Copy link

Hello.

I was working on building cadvisor for Gentoo and I noticed by running go mod tidy on v0.36.0 that the go.mod/sum files are out of date.
Can we have a 0.36.1 that just updates the go.mod, go.sum and vendor directories for 0.36?
I need to use the information from there to create a build script for Gentoo, so this would be very helpful.

Thanks,

William

@dashpole
Copy link
Collaborator

Our release cadence is aligned with kubernetes. Are you unable to vendor by commit hash for some reason?

@williamh
Copy link
Author

Since there is a vendor directory in your repository, we assume that the contents of that directory is up to date. If It isn't, it is easy to ignore this vendor directory and pull down the dependencies based on go.mod/go.sum contents.

Where does your build system pass the "-mod=vendor" flag to go? If I know that I can disable it in my package manager's build script for this release.

@dashpole
Copy link
Collaborator

We recently removed the vendor directory for that very reason.

gentoo-bot pushed a commit to gentoo/gentoo that referenced this issue Mar 30, 2020
This is being done because upstream is removing the vendor directory
from future releases and to fix the build.

We can use the information in go.sum to get the dependencies.

Bug: google/cadvisor#2453
Signed-off-by: William Hubbs <williamh@gentoo.org>
thesamesam pushed a commit to thesamesam/gentoo that referenced this issue Mar 30, 2020
This is being done because upstream is removing the vendor directory
from future releases and to fix the build.

We can use the information in go.sum to get the dependencies.

Bug: google/cadvisor#2453
Signed-off-by: William Hubbs <williamh@gentoo.org>
@williamh
Copy link
Author

As you see in the previous comment, I was able to fix this on the Gentoo side by removing the vendor directory from the build and using the contents of go.sum to determine the dependencies.

Thanks a lot for pointing out that you removed your vendor directory. That will actually make our downstream builds easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants