Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow data to be pushed to influxdb #39

Closed
jchauncey opened this issue Jun 13, 2014 · 20 comments · Fixed by #74 or #80
Closed

allow data to be pushed to influxdb #39

jchauncey opened this issue Jun 13, 2014 · 20 comments · Fixed by #74 or #80

Comments

@jchauncey
Copy link

  • How do you tell cAdvisor which influxdb nodes to use?
  • Should it push the data in realtime or on a timer?

Im guessing eventually this will be the basis for a plugin setup for allowing data to be pushed to other systems like ganglia and graphite.

@vishh
Copy link
Contributor

vishh commented Jun 13, 2014

The plan as you mentioned is to have plugins for different storage
backends.
AFAIK we haven't explored influxdb in detail. Are you interested in working
on adding support for it?

On Fri, Jun 13, 2014 at 11:34 AM, Jonathan Chauncey <
notifications@github.com> wrote:

  • How do you tell cAdvisor which influxdb nodes to use?
  • Should it push the data in realtime or on a timer?

Im guessing eventually this will be the basis for a plugin setup for
allowing data to be pushed to other systems like ganglia and graphite.


Reply to this email directly or view it on GitHub
#39.

@jchauncey
Copy link
Author

yeah I think im going to take a stab at it. Im definitely not a go expert but think I can get a working prototype on a branch for you guys to look at.

@vmarmol
Copy link
Contributor

vmarmol commented Jun 13, 2014

Definitely! Let us know how we can help.

@erikh
Copy link

erikh commented Jun 13, 2014

Here's a basic shipper between the cadvisor and influx DB APIs: https://gist.github.com/erikh/fbfe6dadc938cf815435

I'll be working on this a bit as well. If you'd like to collaborate @jchauncey, please lmk.

@josephruscio
Copy link

+1 to plugins for different storage backends, we could put a @librato plugin together then :-)

@vmarmol
Copy link
Contributor

vmarmol commented Jun 14, 2014

@monnand started work to refactor the existing code to make it easier to add these drivers. So hopefully by next week you'll be able to add many different drivers for storage backends.

@monnand
Copy link
Collaborator

monnand commented Jun 17, 2014

#58 is the last PR to add storage drivers into cAdvisor. Once we got this merged, I will work on other storage backends like influxdb and BigQuery (which is mentioned in #43)

@erikh
Copy link

erikh commented Jun 17, 2014

On Jun 17, 2014, at 1:55 PM, monnand notifications@github.com wrote:

#58 is the last PR to add storage drivers into cAdvisor. Once we got this merged, I will work on other storage backends like influxdb and BigQuery (which is mentioned in #43)

Can I take influx? I can probably have it banged out later this week.

-Erik

@vmarmol
Copy link
Contributor

vmarmol commented Jun 17, 2014

@erikh that SGTM. Only question I have there is if it can be run within the same process as the rest of cAdvisor

@erikh
Copy link

erikh commented Jun 17, 2014

On Jun 17, 2014, at 2:15 PM, Victor Marmol notifications@github.com wrote:

@erikh that SGTM. Only question I have there is if it can be run within the same process as the rest of cAdvisor

I’ll investigate this but it might not be possible. What would you suggest in lieu of that?

-Erik

@vmarmol
Copy link
Contributor

vmarmol commented Jun 17, 2014

I just wanted to keep us from depending on another process running, but if there is nothing we can do then we can go that route.

@monnand
Copy link
Collaborator

monnand commented Jun 17, 2014

@erikh Thanks! You could take a look at the storage package and implement the StorageDriver interface. I probably will add a Close() error method to the interface, which seems useful.

@jchauncey
Copy link
Author

Why isnt this configurable? Its memory by default and you can set a flag to push to influx.

@monnand
Copy link
Collaborator

monnand commented Jun 17, 2014

@jchauncey Yes. I think that would be better. The only reason I didn't make it configurable is because we only have one storage driver now. Once we add more drivers, we should let users to choose which one they want to use.

@vmarmol
Copy link
Contributor

vmarmol commented Jun 17, 2014

👍 to configurable. For now we only have one option :D

With @monnand's StorageDriver PRs we should be able to take any of these easily

@tamsky
Copy link

tamsky commented Jun 29, 2014

👍 to not restricting the implementation of this to a single service.

Being able to actively push to multiple distinct backend services, concurrently, is super desirable.

@rjnagal
Copy link
Contributor

rjnagal commented Jul 1, 2014

@erikh Do you have a patch we can collaborate on?

@erikh
Copy link

erikh commented Jul 1, 2014

Unfortunately I have not had time to do this.

If you want to take it, go for it.

-Erik

On Jul 1, 2014, at 1:40 PM, Rohit Jnagal notifications@github.com wrote:

@erikh Do you have a patch we can collaborate on?


Reply to this email directly or view it on GitHub.

@monnand
Copy link
Collaborator

monnand commented Jul 2, 2014

Working on this issue today. But failed to use the influxdb's Go library. Posted a message on their mailing list. https://groups.google.com/forum/#!topic/influxdb/FDU6ELiICGo

@vmarmol
Copy link
Contributor

vmarmol commented Jul 7, 2014

The initial version of this is done with @monnand's #74. Feel free to open other issues for details that may be missing :)

@monnand monnand mentioned this issue Jul 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
8 participants