Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize NewRealSysFs() #1578

Merged
merged 1 commit into from
Mar 15, 2017
Merged

optimize NewRealSysFs() #1578

merged 1 commit into from
Mar 15, 2017

Conversation

NickrenREN
Copy link
Contributor

remove second return value since it will never return err

@k8s-ci-robot
Copy link
Collaborator

Hi @NickrenREN. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@NickrenREN NickrenREN closed this Feb 16, 2017
@NickrenREN NickrenREN reopened this Feb 16, 2017
@NickrenREN
Copy link
Contributor Author

@k8s-bot test this

@dashpole dashpole self-assigned this Mar 15, 2017
@dashpole
Copy link
Collaborator

Thanks for your PR! The code changes look good. Please rebase, and reply to this PR to let me know!

@NickrenREN
optimize NewRealSysFs()
a248c34 
remove second return value since it will never return err
@NickrenREN
Copy link
Contributor Author

@dashpole Thanks. Done, ptal

@dashpole dashpole merged commit fb28b0d into google:master Mar 15, 2017
@NickrenREN NickrenREN deleted the sysfs-new branch March 15, 2017 05:36
@NickrenREN NickrenREN mentioned this pull request Mar 15, 2017
Closed
@mkumatag mkumatag mentioned this pull request Apr 6, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dashpole dashpole dashpole approved these changes

Assignees

@dashpole dashpole

Labels
kind/cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NickrenREN @k8s-ci-robot @dashpole