New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide PSR information for containers. #2291
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Hi @mJace. Thanks for your PR. I'm waiting for a google or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
/ok-to-test |
/retest |
@dashpole How do I run the test in my fork? |
Try just running |
@dashpole Sorry, I have some problem reproducing the I have this error when running But if I manually copy 3 modified files to my local google/master and run |
ah, apologies. I forgot about some changes we made to scripts a while back. It looks like there is a bug with the script that actually runs I opened #2296 to fix the print statement. |
@dashpole Cuz, I still have trouble to run But it seems like they are 2 different problems? |
Yeah, you are correct. To fix the failure here, run My PR just fixes the error message from #2291 (comment) so it tells you how to fix that problem. |
I see, thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
sorry, if you can rebase this, i'm happy to merge it. |
@dashpole Thank you!
Can you check this for me? I tried go v1.11 v1.12 v1.13 Or can I ignore the build error on latest master branch, just rebase my branch on google:master ? |
I would just rebase on master. If it has problems, you can check the logs from the presubmits if you can't get it working in your dev env. I think we use go 1.14 now btw |
@dashpole I rebased my branch. Could you take a look? thank you! |
Allow cadvisor to provide PSR information when doing
ps
to containers now.PSR is a
ps
output option, it shows which cpu that current process runs on.The related issue:
#2290