Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prometheus/client_golang to v1.7.1 #2605

Merged
merged 1 commit into from Jun 30, 2020
Merged

Update prometheus/client_golang to v1.7.1 #2605

merged 1 commit into from Jun 30, 2020

Conversation

nightah
Copy link
Contributor

@nightah nightah commented Jun 30, 2020

A bug was identified in the upstream library which stops cadvisor from collecting and reporting metrics.
This was resolved in v1.5.1.

This PR updates said library to the latest version available v1.7.1.

Fixes #2537.

@k8s-ci-robot
Copy link
Collaborator

Hi @nightah. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dashpole
Copy link
Collaborator

/ok-to-test

Copy link
Collaborator

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dashpole dashpole merged commit 59f894a into google:master Jun 30, 2020
@nightah nightah deleted the update-prom-client-golang branch July 1, 2020 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

http: superfluous response.WriteHeader
3 participants