Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add clean operation when watchForNewContainers/Start failed #2665

Merged
merged 1 commit into from Sep 11, 2020

Conversation

nicktming
Copy link
Contributor

@nicktming nicktming commented Sep 7, 2020

when watchForNewContainers and rawContainerWatcher Start fails and return err, but it does not have some clean operations since some ContainerWatchers already execute the Start() functions. so this commit tries to add clean operations when this happens.

@google-cla
Copy link

google-cla bot commented Sep 7, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@k8s-ci-robot
Copy link
Collaborator

Hi @nicktming. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nicktming
Copy link
Contributor Author

@googlebot I signed it!

@dashpole
Copy link
Collaborator

dashpole commented Sep 9, 2020

/ok-to-test

would you mind adding a description of why we want to make the change?

@nicktming
Copy link
Contributor Author

/ok-to-test

would you mind adding a description of why we want to make the change?

ok.

Copy link
Collaborator

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dashpole dashpole merged commit b1f68d4 into google:master Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants