Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting fixes to #2792 and #2798 to v0.37 #2807

Merged
merged 2 commits into from
Feb 18, 2021

Conversation

iwankgb
Copy link
Collaborator

@iwankgb iwankgb commented Feb 17, 2021

Porting of recent fixes applied to master.

@google-cla
Copy link

google-cla bot commented Feb 17, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Feb 17, 2021
@iwankgb
Copy link
Collaborator Author

iwankgb commented Feb 17, 2021

@Creatone can you add a comment in this PR too, please?

@Creatone
Copy link
Collaborator

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Feb 17, 2021
@iwankgb iwankgb changed the title Porting fixes to #2792 and #2798 to v0.37 Porting fixes to #2792 and #2798, and libimpctl in Dockerfile to v0.37 Feb 17, 2021
@iwankgb iwankgb changed the title Porting fixes to #2792 and #2798, and libimpctl in Dockerfile to v0.37 Porting fixes to #2792 and #2798 to v0.37 Feb 17, 2021
@bobbypage
Copy link
Collaborator

bobbypage commented Feb 18, 2021

LGTM, thanks to both of you for the fixes!

@bobbypage bobbypage merged commit ebe58af into google:release-v0.37 Feb 18, 2021
@bobbypage
Copy link
Collaborator

https://github.com/google/cadvisor/releases/tag/v0.37.5 has been cut with this included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants