Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "dockerfile: Fix typo in go build tags." #3250

Merged
merged 1 commit into from Feb 19, 2023

Conversation

bobbypage
Copy link
Collaborator

Reverts #3237

This is breaking the release build:

$ make release

...


#19 [build 12/12] RUN export GO_TAGS="--tags=libpfm,netgo";     if [ "$(uname --machine)" = "x86_64" ]; then           export GO_TAGS="$GO_TAGS,libipmctl";     fi;     GO_FLAGS="$GO_TAGS" ./build/build.sh
#19 1.443 >> building cadvisor
#19 73.36 # github.com/google/cadvisor/perf
#19 73.36 ../perf/collector_libpfm.go:256:34: cannot use _Ctype_ulong(unsafe.Sizeof(unix.PerfEventAttr{})) (constant 128 of type _Ctype_ulong) as type _Ctype_uint in argument to (_Cfunc__CMalloc)
#19 73.36 ../perf/collector_libpfm.go:258:61: cannot use _Ctype_ulong(unsafe.Sizeof(unix.PerfEventAttr{})) (constant 128 of type _Ctype_ulong) as type _Ctype_uint in variable declaration
#19 73.36 ../perf/collector_libpfm.go:271:15: cannot use _Ctype_ulong(unsafe.Sizeof(event)) (constant 24 of type _Ctype_ulong) as type _Ctype_uint in assignment
#19 ERROR: process "/bin/sh -c export GO_TAGS=\"--tags=libpfm,netgo\";     if [ \"$(uname --machine)\" = \"x86_64\" ]; then           export GO_TAGS=\"$GO_TAGS,libipmctl\";     fi;     GO_FLAGS=\"$GO_TAGS\" ./build/build.sh" did not complete successfully: exit code: 2
------
 > [build 12/12] RUN export GO_TAGS="--tags=libpfm,netgo";     if [ "$(uname --machine)" = "x86_64" ]; then           export GO_TAGS="$GO_TAGS,libipmctl";     fi;     GO_FLAGS="$GO_TAGS" ./build/build.sh:
#19 1.443 >> building cadvisor
#19 73.36 # github.com/google/cadvisor/perf
#19 73.36 ../perf/collector_libpfm.go:256:34: cannot use _Ctype_ulong(unsafe.Sizeof(unix.PerfEventAttr{})) (constant 128 of type _Ctype_ulong) as type _Ctype_uint in argument to (_Cfunc__CMalloc)
#19 73.36 ../perf/collector_libpfm.go:258:61: cannot use _Ctype_ulong(unsafe.Sizeof(unix.PerfEventAttr{})) (constant 128 of type _Ctype_ulong) as type _Ctype_uint in variable declaration
#19 73.36 ../perf/collector_libpfm.go:271:15: cannot use _Ctype_ulong(unsafe.Sizeof(event)) (constant 24 of type _Ctype_ulong) as type _Ctype_uint in assignment
------
Dockerfile:43
--------------------
  42 |     # libipmctl only works on x86_64 CPUs.
  43 | >>> RUN export GO_TAGS="--tags=libpfm,netgo"; \
  44 | >>>     if [ "$(uname --machine)" = "x86_64" ]; then \
  45 | >>>           export GO_TAGS="$GO_TAGS,libipmctl"; \
  46 | >>>     fi; \
  47 | >>>     GO_FLAGS="$GO_TAGS" ./build/build.sh
  48 |
--------------------
ERROR: failed to solve: process "/bin/sh -c export GO_TAGS=\"--tags=libpfm,netgo\";     if [ \"$(uname --machine)\" = \"x86_64\" ]; then           export GO_TAGS=\"$GO_TAGS,libipmctl\";     fi;     GO_FLAGS=\"$GO_TAGS\" ./build/build.sh" did not complete successfully: exit code: 2
make: *** [Makefile:69: release] Error 1

See full logs - https://gist.github.com/bobbypage/25570419f1d59f7b0fcbae9f1540be5b

@bobbypage
Copy link
Collaborator Author

@Creatone lets revert this for now, if you can, please update the PR to also fix the build with make release. Thank you!

@k8s-ci-robot
Copy link
Collaborator

@bobbypage: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cadvisor-e2e ed253fb link true /test pull-cadvisor-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bobbypage bobbypage merged commit 473d158 into master Feb 19, 2023
@iwankgb iwankgb deleted the revert-3237-creatone/dockerfile-fix branch February 20, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants