Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: bump runc to 1.1.9 #3373

Merged
merged 1 commit into from Aug 16, 2023
Merged

Conversation

haircommander
Copy link
Contributor

to fix an issue with cgroupv2 memory accounting not being accurate

@k8s-ci-robot
Copy link
Collaborator

Hi @haircommander. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kolyshkin
Copy link
Contributor

@haircommander I think you forgot to run go mod tidy.

@haircommander
Copy link
Contributor Author

hm, running it doesn't change the files there

@bobbypage
Copy link
Collaborator

@haircommander can you please rebase to include #3380? That should fix the issues with the CI. Thank you!

@haircommander
Copy link
Contributor Author

yeah I've rebased and definitely have the fixes. Any hints here?

@bobbypage
Copy link
Collaborator

Can you run make tidy?

to fix an issue with cgroupv2 memory accounting not being accurate

Signed-off-by: Peter Hunt <pehunt@redhat.com>
@haircommander
Copy link
Contributor Author

ah hah! that was it, thank you

@bobbypage
Copy link
Collaborator

Great! Can you please also remove the change to the .gitignore? I don't think that is needed.

@haircommander
Copy link
Contributor Author

sure, though I added it because the vendor directory is generated when we run go mod vendor but not checked into the repo...

@bobbypage
Copy link
Collaborator

/ok-to-test

@bobbypage
Copy link
Collaborator

sure, though I added it because the vendor directory is generated when we run go mod vendor but not checked into the repo...

gotcha, we don't vendor in cadvisor, so there shouldn't be a vendor directory and running go mod vendor shouldn't be necessary.

@bobbypage bobbypage merged commit 1f17a6c into google:master Aug 16, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants